On Tuesday 12 May 2009 08:39:49 Johannes Berg wrote:
> On Tue, 2009-05-12 at 01:09 +0200, Christian Lamparter wrote:
>
> > + if ((ar->tx_stats[i].len < ar->tx_stats[i].limit) &&
> > + (ieee80211_queue_stopped(ar->hw, i)))
> > + ieee80211_wake_queue(ar->hw, i);
>
> There's no reason to test _stopped first, and doing so is racy.
uhh, agreed _stopped is not necessary, but where's the race condition?
>
> > if (changed & IEEE80211_CONF_CHANGE_CHANNEL) {
> > + err = ar9170_stop_and_flush_queues(ar);
> > + if (err)
> > + goto out;
>
> Why don't you do that in the pre-scan method?
dunno, will pre_scan cb code end up in 2.6.30 as well?
Regards,
Chr
--
To unsubscribe from this list: send the line "unsubscribe linux-wireless" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
