Search Linux Wireless

Re: [PATCH] cfg80211: fix race condition with wiphy_apply_custom_regulatory()

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On 5/1/09, Luis R. Rodriguez <lrodriguez@xxxxxxxxxxx> wrote:
> We forgot to lock using the cfg80211_mutex in
> wiphy_apply_custom_regulatory(). Without the lock
> there is possible race between processing a reply from CRDA
> and a driver calling wiphy_apply_custom_regulatory(). During
> the processing of the reply from CRDA we free last_request and
> wiphy_apply_custom_regulatory() eventually accesses an
> element from last_request in the through freq_reg_info_regd().
>
> This is very difficult to reproduce (I haven't), it takes us
> 3 hours and you need to be banging hard, but the race is obvious
> by looking at the code.
>
> This should only affect those who use this caller, which currently
> is ath5k, ath9k, and ar9170.
>
> EIP: 0060:[<f8ebec50>] EFLAGS: 00210282 CPU: 1
> EIP is at freq_reg_info_regd+0x24/0x121 [cfg80211]

This looks like the same bug I reported seeing on bootup (100% of the
time).  I'll test wireless-testing again for V9 of the rfkill rewrite,
so at that point I'll try to confirm that this patch fixes my problem.

Thanks!
Alan
--
To unsubscribe from this list: send the line "unsubscribe linux-wireless" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html

[Index of Archives]     [Linux Host AP]     [ATH6KL]     [Linux Bluetooth]     [Linux Netdev]     [Kernel Newbies]     [Linux Kernel]     [IDE]     [Security]     [Git]     [Netfilter]     [Bugtraq]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Linux ATA RAID]     [Samba]     [Device Mapper]
  Powered by Linux