On Thu, 2009-04-23 at 20:49 +0300, Kalle Valo wrote: > No problem, I can update wl12xx as soon as you finalise the interface. > Just let me know. Well, I just posted it earlier as [PATCH] :) > > wl12xx_cmd_template_set(wl, CMD_PROBE_RESP, beacon->data, > > > > hmm. mac80211 doesn't deal with probe response offload right now. > > Yeah. You're not setting the IBSS bit anyway though. ;) Might need to come up with a patch to disable mac80211 probe responses, that would be much more efficient... > > status->flag |= RX_FLAG_TSFT; > > > > You should set that only when it's actually completely filled I think. > > p54 has a trick to keep track of the upper 32 bits in software, > > This would help. > > > that assumes getting a frame every 2**32 us though. > > But we can check that in driver and compensate, right? Well, you can check against jiffies and then resync with the get_tsf command, I guess. > > how about IPv4 alignment? Could you read the packet header first, > > memmove that and then read the rest, i.e. do two wl12xx_spi_mem_read > > calls? Might or might not be more efficient... > > SPI access add latency, it would be faster to read as much as possible > in one transaction. Question is how it measures against the CPU doing memmove() on the entire frame when necessary. > Is there anything which in your opinion prevents inclusion to > wireless-testing? Give that you and Bob are working on it, I don't think so. Except the API issue, which means it won't compile when John merges my patch. johannes
Attachment:
signature.asc
Description: This is a digitally signed message part
