Hi,
A couple of comments.
It clashes with the patches that I just posted to remove
config_interface in favour of only using bss_info_changed.
This:
if (memcmp(wl->mac_addr, conf->mac_addr, ETH_ALEN)) {
memcpy(wl->mac_addr, conf->mac_addr, ETH_ALEN);
SET_IEEE80211_PERM_ADDR(wl->hw, wl->mac_addr);
is strange in wl12xx_op_add_interface for sure. Should at least be in
->start() if you can't read it before. Or is that trying to override the
address the user assigned??
wl12xx_op_remove_interface ought to clear the device's address to stop
acking frames.
wl12xx_cmd_template_set(wl, CMD_PROBE_RESP, beacon->data,
hmm. mac80211 doesn't deal with probe response offload right now.
/*
* We enter PSM only if we're already associated.
* If we're not, we'll enter it when joining an SSID,
* through the bss_info_changed() hook.
*/
Umm, mac80211 only enables CONF_PS after associating. So psm_requested
is unnecessary.
wl12xx_build_basic_rates and wl12xx_build_extended_rates are unnecessary
-- use scan_req->ie and set the IE max length. Similarly
wl12xx_build_probe_req should be reduced a lot (to just putting in the
SSID). You could also support the channels passed in the scan request.
wl->hw->flags = IEEE80211_HW_SIGNAL_DBM |
IEEE80211_HW_NOISE_DBM;
No powersave bits?
MODULE_AUTHOR("Kalle Valo <Kalle.Valo@xxxxxxxxx>, "
"Luciano Coelho <luciano.coelho@xxxxxxxxx>");
Use multiple MODULE_AUTHOR() macros.
/*
* The rx status timestamp is a 32 bits value while the TSF is a
* 64 bits one.
* For IBSS merging, TSF is mandatory, so we have to get it
* somehow, so we ask for ACX_TSF_INFO.
* That could be moved to the get_tsf() hook, but unfortunately,
* this one must be atomic, while our SPI routines can sleep.
*/
if ((wl->bss_type == BSS_TYPE_IBSS) && beacon) {
If the chip supports a good filter flags set it could be useful for
monitoring to always do this if monitor is enabled. Not really necessary
though.
status->flag |= RX_FLAG_TSFT;
You should set that only when it's actually completely filled I think.
p54 has a trick to keep track of the upper 32 bits in software, that
assumes getting a frame every 2**32 us though.
skb = dev_alloc_skb(length);
if (!skb) {
wl12xx_error("Couldn't allocate RX frame");
return;
}
rx_buffer = skb_put(skb, length);
how about IPv4 alignment? Could you read the packet header first,
memmove that and then read the rest, i.e. do two wl12xx_spi_mem_read
calls? Might or might not be more efficient...
You need to rm wl12xx_80211.h and use linux/ieee80211.h, extending where
necessary.
johannes
Attachment:
signature.asc
Description: This is a digitally signed message part
