On Mon, 2009-04-20 at 23:19 +0200, Davide Pesavento wrote: > >> As I've already reported [1][2], ath9k is currently broken when power > >> saving is enabled, at least on AR5418 hardware. So please don't turn > >> it on by default yet. > > > > But if that's just a hardware/driver bug shouldn't the driver disable PS > > for that combination? It seems wrong to disable PS in the stack by > > default just because one driver has a problem with it, when that driver > > could just unset the PS support bit. > > > > You're right. It makes perfect sense. > Unfortunately I don't know how to do it... :-( Something like this. johannes --- wireless-testing.orig/drivers/net/wireless/ath/ath9k/main.c 2009-04-20 23:27:15.000000000 +0200 +++ wireless-testing/drivers/net/wireless/ath/ath9k/main.c 2009-04-20 23:27:54.000000000 +0200 @@ -1537,8 +1537,6 @@ void ath_set_hw_capab(struct ath_softc * IEEE80211_HW_HOST_BROADCAST_PS_BUFFERING | IEEE80211_HW_SIGNAL_DBM | IEEE80211_HW_AMPDU_AGGREGATION | - IEEE80211_HW_SUPPORTS_PS | - IEEE80211_HW_PS_NULLFUNC_STACK | IEEE80211_HW_SPECTRUM_MGMT; if (AR_SREV_9160_10_OR_LATER(sc->sc_ah) || modparam_nohwcrypt) -- To unsubscribe from this list: send the line "unsubscribe linux-wireless" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
