On Mon, Apr 20, 2009 at 21:53, Johannes Berg <johannes@xxxxxxxxxxxxxxxx> wrote: > On Mon, 2009-04-20 at 15:44 -0400, John W. Linville wrote: >> On Thu, Apr 16, 2009 at 01:17:23PM +0200, Johannes Berg wrote: >> > This is pretty much unchanged from my previous v2 RFCs, >> > except that I added a default of 500ms for the dynamic >> > powersave timer. >> > >> > The fourth patch is new, it adds beacon filtering to >> > mac80211 -- for the reasons explained in that patch. >> > >> > For 2.6.31, we should make MAC80211_DEFAULT_PS default >> > off instead. John, how do you want to handle that? >> >> I'm not sure I understand. Your patch (which would go to 2.6.31) >> has it turned-on by default. Which way do you want it? > > I want it turned on by default, at least in wireless-testing; Kalle > thinks that we should turn it off for a .31 release. > > I would think that since an easy workaround is available ("iwconfig > wlan0 power off") and it doesn't affect most hardware yet anyway (only > those supporting powersave) we should turn it on by default anyway, > since otherwise we won't find any bugs -- but maybe that's just me. > As I've already reported [1][2], ath9k is currently broken when power saving is enabled, at least on AR5418 hardware. So please don't turn it on by default yet. Thanks, Davide [1] http://marc.info/?l=linux-wireless&m=123816406913599&w=2 [2] http://marc.info/?l=linux-wireless&m=123999864507104&w=2 -- To unsubscribe from this list: send the line "unsubscribe linux-wireless" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html