Johannes Berg wrote: > On Mon, 2009-04-20 at 09:33 +0100, Alan Jenkins wrote: > > >> Ok, revised patch is below. Don't forget the set_sw_state() -> >> set_global_sw_state() change; I didn't include that. >> > > Ok, will do. Thanks for the patch, I'll integrate it into mine. > > >> Note that there other pending changes to the rfkill code in eeepc-laptop. >> >> "[PATCH] eee-laptop: Register as a pci-hotplug device" >> <http://thread.gmane.org/gmane.linux.kernel/791730/focus=38724> >> >> "[PATCH] eeepc-laptop: Work around rfkill firmware bug" >> <http://thread.gmane.org/gmane.linux.acpi.devel/38424> >> >> The second is mine; sorry for not warning about it sooner. So you/we >> probably need to co-ordinate with the maintainer. I'd CC linux-acpi, >> because that's where most platform driver changes are submitted. >> > > Ok, thanks for the heads up. Do you think this will generate significant > conflicts? > I'm not quite sure what would be considered significant, but it's not trivial. At a high level, I don't think the new behaviours conflict with the new rfkill semantics :-). But the firmware bug workaround can't be resolved completely mechanically. And the pci-hotplug patch touches the rfkill error path. -- To unsubscribe from this list: send the line "unsubscribe linux-wireless" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
