On Tue, Apr 07, 2009 at 03:08:45AM -0700, Johannes Berg wrote: > On Mon, 2009-04-06 at 16:15 -0400, Luis R. Rodriguez wrote: > > > +static bool is_ht40_not_allowed(struct ieee80211_channel *chan) > > I think it would be nicer on the reader to remove the not? > > > +{ > > + if (!chan) > > + return true; > > + if (chan->flags & IEEE80211_CHAN_DISABLED) > > + return true; > > + /* This would happen when regulatory rules disallow HT40 completely */ > > + if (IEEE80211_CHAN_NO_HT40 == (chan->flags & (IEEE80211_CHAN_NO_HT40))) > > + return true; > > How would that happen at this point? Due to the regulatory freq rule. > /me stops reading. > > Ok, whatever, I know I want to rewrite most of this anyway. :) -- To unsubscribe from this list: send the line "unsubscribe linux-wireless" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html