Search Linux Wireless

Re: [PATCH v2 1/5] cfg80211: Process regulatory max bandwidth checks for HT40

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Mon, 2009-04-06 at 16:15 -0400, Luis R. Rodriguez wrote:

> +static bool is_ht40_not_allowed(struct ieee80211_channel *chan)

I think it would be nicer on the reader to remove the not?

> +{
> +	if (!chan)
> +		return true;
> +	if (chan->flags & IEEE80211_CHAN_DISABLED)
> +		return true;
> +	/* This would happen when regulatory rules disallow HT40 completely */
> +	if (IEEE80211_CHAN_NO_HT40 == (chan->flags & (IEEE80211_CHAN_NO_HT40)))
> +		return true;

How would that happen at this point?

/me stops reading.

Ok, whatever, I know I want to rewrite most of this anyway.

johannes

Attachment: signature.asc
Description: This is a digitally signed message part


[Index of Archives]     [Linux Host AP]     [ATH6KL]     [Linux Bluetooth]     [Linux Netdev]     [Kernel Newbies]     [Linux Kernel]     [IDE]     [Security]     [Git]     [Netfilter]     [Bugtraq]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Linux ATA RAID]     [Samba]     [Device Mapper]
  Powered by Linux