> > > what do you think about the attached proposal? > > > > It looks generally better. But (fw + offset) wouldn't compile, because > > fw is void*. > > ??? but it does compile?! > CHECK drivers/net/wireless/p54/p54spi.c > CC [M] drivers/net/wireless/p54/p54spi.o > Building modules, stage 2. > MODPOST 4 modules > CC drivers/net/wireless/p54/p54spi.mod.o > LD [M] drivers/net/wireless/p54/p54spi.ko > > But yes, I agree we better change void *fw to u8 *fw. > > BTW: does p54spi really work now? Now firmware uploading code works fine. It even successfully uploads firmware in small chunks. -- Thanks. -- Max -- To unsubscribe from this list: send the line "unsubscribe linux-wireless" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html