Search Linux Wireless

Re: [PATCH 2/2 v2] p54spi: fix p54spi_upload_firmware

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



> > > what do you think about the attached proposal?
> >
> > It looks generally better. But (fw + offset) wouldn't compile, because
> > fw is void*.
>
> ??? but it does compile?!
>   CHECK   drivers/net/wireless/p54/p54spi.c
>   CC [M]  drivers/net/wireless/p54/p54spi.o
>  Building modules, stage 2.
>   MODPOST 4 modules
>   CC      drivers/net/wireless/p54/p54spi.mod.o
>   LD [M]  drivers/net/wireless/p54/p54spi.ko
>
> But yes, I agree we better change void *fw to u8 *fw.
>
> BTW: does p54spi really work now?
Now firmware uploading code works fine. It even successfully uploads firmware 
in small chunks.

-- 
Thanks.
-- Max
--
To unsubscribe from this list: send the line "unsubscribe linux-wireless" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html

[Index of Archives]     [Linux Host AP]     [ATH6KL]     [Linux Bluetooth]     [Linux Netdev]     [Kernel Newbies]     [Linux Kernel]     [IDE]     [Security]     [Git]     [Netfilter]     [Bugtraq]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Linux ATA RAID]     [Samba]     [Device Mapper]
  Powered by Linux