Search Linux Wireless

Re: [PATCH 2/2] p54spi: fix p54_upload_firmware

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



> checkpatch.pl complains
>
> WARNING: line over 80 characters
> #94: FILE: drivers/net/wireless/p54/p54spi.c:269:
> +                       void *fw = kmemdup(priv->firmware->data, _fw_len, GFP_KERNEL);
>
> ERROR: that open brace { should be on the previous line
> #95: FILE: drivers/net/wireless/p54/p54spi.c:270:
> +                       if (fw)
> +                       {
>
Sorry, I haven't been used to checkpatch.

> what do you think about the attached proposal?

It looks generally better. But (fw + offset) wouldn't compile, because
fw is void*.

-- 
Max
--
To unsubscribe from this list: send the line "unsubscribe linux-wireless" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html

[Index of Archives]     [Linux Host AP]     [ATH6KL]     [Linux Bluetooth]     [Linux Netdev]     [Kernel Newbies]     [Linux Kernel]     [IDE]     [Security]     [Git]     [Netfilter]     [Bugtraq]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Linux ATA RAID]     [Samba]     [Device Mapper]
  Powered by Linux