On Sat, 2009-03-21 at 17:56 +0100, Johannes Berg wrote: > > What about memory allocation failures? > > I think we should check for an error and if one occurs take the interface > > completely down and return the error to userspace. > > Makes sense, need to audit the code though to verify that > ieee80211_stop() doesn't puke if you call it twice in a row (since > dev_close() will call it again) In fact, it is _not_ safe to do that, the iff_allmultis/promiscs counters for example will be wrong. Easily worked around though -- shortcut the function if you realise it was already called. johannes
Attachment:
signature.asc
Description: This is a digitally signed message part
