On Sat, 2009-03-21 at 17:45 +0100, Michael Buesch wrote:
> > - return 0;
> > + if (running) {
> > + ret = ieee80211_open(sdata->dev);
> > + if (ret) {
> > + /*
> > + * ieee80211_open could fail, for example if the user
> > + * wants to have an interface combination now that we
> > + * do not support -- in that case roll back. This has
> > + * to succeed unless we have a driver/mac80211 bug,
> > + * since the interface was there before!
>
> What about memory allocation failures?
> I think we should check for an error and if one occurs take the interface
> completely down and return the error to userspace.
Makes sense, need to audit the code though to verify that
ieee80211_stop() doesn't puke if you call it twice in a row (since
dev_close() will call it again)
It's only proof-of-concept code -- like I said, I have no interest in
it.
johannes
Attachment:
signature.asc
Description: This is a digitally signed message part
