Johannes Berg <johannes@xxxxxxxxxxxxxxxx> writes: > On Wed, 2009-03-18 at 11:25 +0200, Kalle Valo wrote: > >> + /* >> + * When software scanning only nullfunc frames (to notify >> + * the sleep state to the AP) and probe requests (for the >> + * active scan) are allowed, everything else should be >> + * dropped. See ieee80211_start_scan() for more. >> + */ >> return TX_DROP; > > That makes it sounds "too correct" to drop frames it seems. Should we > say something like > > ... and probe requests (...) are allowed, all other frames > should not be sent and we should not get here, but if we do > nonetheless,drop them to avoid sending them off-channel. > > Or even add this link: > http://article.gmane.org/gmane.linux.kernel.wireless.general/30089 Ok, I'll improve it. > (you also forgot to s/null/nullfunc/ in the subject :) ) Heh, I'll fix that. v4 coming up. -- Kalle Valo -- To unsubscribe from this list: send the line "unsubscribe linux-wireless" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
