Search Linux Wireless

Re: [PATCH v3] mac80211: don't drop null frames during software scan

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Wed, 2009-03-18 at 11:25 +0200, Kalle Valo wrote:

> diff --git a/net/mac80211/tx.c b/net/mac80211/tx.c
> index 457238a..525d261 100644
> --- a/net/mac80211/tx.c
> +++ b/net/mac80211/tx.c
> @@ -193,7 +193,14 @@ ieee80211_tx_h_check_assoc(struct ieee80211_tx_data *tx)
>  		return TX_CONTINUE;
>  
>  	if (unlikely(tx->local->sw_scanning) &&
> -	    !ieee80211_is_probe_req(hdr->frame_control))
> +	    !ieee80211_is_probe_req(hdr->frame_control) &&
> +	    !ieee80211_is_nullfunc(hdr->frame_control))
> +		/*
> +		 * When software scanning only nullfunc frames (to notify
> +		 * the sleep state to the AP) and probe requests (for the
> +		 * active scan) are allowed, everything else should be
> +		 * dropped. See ieee80211_start_scan() for more.
> +		 */
>  		return TX_DROP;

That makes it sounds "too correct" to drop frames it seems. Should we
say something like

	... and probe requests (...) are allowed, all other frames
	should not be sent and we should not get here, but if we do
	nonetheless,drop them to avoid sending them off-channel.

Or even add this link:
http://article.gmane.org/gmane.linux.kernel.wireless.general/30089

(you also forgot to s/null/nullfunc/ in the subject :) )

johannes

Attachment: signature.asc
Description: This is a digitally signed message part


[Index of Archives]     [Linux Host AP]     [ATH6KL]     [Linux Bluetooth]     [Linux Netdev]     [Kernel Newbies]     [Linux Kernel]     [IDE]     [Security]     [Git]     [Netfilter]     [Bugtraq]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Linux ATA RAID]     [Samba]     [Device Mapper]
  Powered by Linux