2009/3/11 Johannes Berg <johannes@xxxxxxxxxxxxxxxx>: > On Wed, 2009-03-11 at 09:07 -0700, Luis R. Rodriguez wrote: > >> > This is utterly insane. Just make it _always_ do the spinlock, and get >> > rid of the hotplug notifier and all that crap. >> >> That is certainly an option as well but we would obviously be incurring >> the lock on all reads/writes regardless of what bus you use which is >> not necessary. We'll review this and determine whether its worth it. > > Hmm. I really don't understand this at all. Most operations won't be > single writes and reads, and if you need multiple like a write+read for > indirect register accesses then I'm sure you need to serialise them > against each other in some other way too, no? The issue is not serializing against separate routines calling some reads or writes, this serialization prevents the PCI hardware FIFO queue from getting more than two requests as otherwise the hardware poops out. But as you can see this is only an issue with PCI devices, not PCI express devices. Luis -- To unsubscribe from this list: send the line "unsubscribe linux-wireless" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
