On Tue, 2009-03-10 at 22:52 -0400, Luis R. Rodriguez wrote:
> + if (ah->config.serialize_regmode == SER_REG_MODE_ON) {
> + unsigned long flags;
> + spin_lock_irqsave(&ah->ah_sc->sc_serial_rw, flags);
> + iowrite32(val, ah->ah_sc->mem + reg_offset);
> + spin_unlock_irqrestore(&ah->ah_sc->sc_serial_rw, flags);
> + } else
> + iowrite32(val, ah->ah_sc->mem + reg_offset);
This is utterly insane. Just make it _always_ do the spinlock, and get
rid of the hotplug notifier and all that crap.
johannes
Attachment:
signature.asc
Description: This is a digitally signed message part
