Search Linux Wireless

Re: [RFC] zd1211rw: remove zd_addr_t typedef for a simple u16

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Luis R. Rodriguez wrote:
It would seem to make the code cleaner and more legible but it just fixed a
sparse warning for me. Unfortunately I don't have an old zydas hardware to
test it with too though.

The line in question:
	if (int_num == CR_INTERRUPT) {

The usage of CR_INTERRUPT wrong here; in this specific case, we are not looking to match a register address. It's a separate constant which is also treated separately from register addresses in the zydas documentation.

CR_INTERRUPT should be replaced with 0x9510, or perhaps a new constant e.g.
#define INTR_STS1_MAC_INTERRUPT 0x9510

I'm afraid that I don't have any hardware here to test with either, but the above change should be safe enough to go through without testing.

Thanks,
Daniel

--
To unsubscribe from this list: send the line "unsubscribe linux-wireless" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html

[Index of Archives]     [Linux Host AP]     [ATH6KL]     [Linux Bluetooth]     [Linux Netdev]     [Kernel Newbies]     [Linux Kernel]     [IDE]     [Security]     [Git]     [Netfilter]     [Bugtraq]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Linux ATA RAID]     [Samba]     [Device Mapper]
  Powered by Linux