On Tue, Mar 10, 2009 at 06:26:11AM -0700, Daniel Drake wrote: > Luis R. Rodriguez wrote: > > The __nocast attribute is used to shut sparse up but we > > don't need it, lets just use u16 directly. > > Which warning does this remove? Yeah sorry, I should have added that, here it is: CHECK drivers/net/wireless/zd1211rw/zd_usb.c drivers/net/wireless/zd1211rw/zd_usb.c:363:24: warning: implicit cast from nocast type CC [M] drivers/net/wireless/zd1211rw/zd_usb.o > The purpose of this system was (I think) to make it so that if you got > addr and value in the wrong order in calls to e.g. zd_ioread16() then > sparse would tell you about it. Looks like your patch would remove that > protection? Sure. > Admittedly it is a bit of a strange thing and no excuse for programmers > getting parameters in the wrong order.. if it needs to go then I'm happy > with whatever you decide. It would seem to make the code cleaner and more legible but it just fixed a sparse warning for me. Unfortunately I don't have an old zydas hardware to test it with too though. Luis -- To unsubscribe from this list: send the line "unsubscribe linux-wireless" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
