Search Linux Wireless

Re: [PATCH 2/2] orinoco: prevent accessing memory outside the firmware image

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



David Kilroy wrote:
> Do this by indicating the end of the appropriate regions of memory.
> 
> Note that MAX_PDA_SIZE should only apply to the PDA block read from
> flash/EEPROM, and has been erronously applied to the pdr elements.
> Remove the macro, and use the actual PDA size passed down by the caller.
> 
> We also fix up some of the types used, marking as much as possible
> const, and using void* for the end pointers.
> 
> Signed-off-by: David Kilroy <kilroyd@xxxxxxxxxxxxxx>
> ---

I've missed (at least) a couple places where I need to add checks:

 * When looking for PDR for Symbol firmware.
 * When applying PDR data I need to check the data is within the FW image

I'll update this patch, address Andreys comments on the other, and resubmit.


Dave.
--
To unsubscribe from this list: send the line "unsubscribe linux-wireless" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html

[Index of Archives]     [Linux Host AP]     [ATH6KL]     [Linux Bluetooth]     [Linux Netdev]     [Kernel Newbies]     [Linux Kernel]     [IDE]     [Security]     [Git]     [Netfilter]     [Bugtraq]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Linux ATA RAID]     [Samba]     [Device Mapper]
  Powered by Linux