Search Linux Wireless

Re: [PATCH] at76_usb: fix Oops on disconnect

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Jason Andryuk <jandryuk@xxxxxxxxx> writes:

> I'll take a look at at76c50x-usb in general and bringing over this
> patch specifically.  Unfortunately, I still had one disconnect oops
> with the patch installed.  Netconsole was not configured, so I did not
> catch it.  There were several other successful disconnects without
> Oops though.

Progress is always good :)

> It may need locking as none is currently present, but does a one way
> transition device_unplugged 0 -> 1 need a lock?

Using int might be enough but I think it's not guarenteed anywhere.
Better to use atomic operations directly or use a proper lock. But I
think the issues are more than that. For example, the disconnect
handler is not taking the mutex.

-- 
Kalle Valo
--
To unsubscribe from this list: send the line "unsubscribe linux-wireless" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html

[Index of Archives]     [Linux Host AP]     [ATH6KL]     [Linux Bluetooth]     [Linux Netdev]     [Kernel Newbies]     [Linux Kernel]     [IDE]     [Security]     [Git]     [Netfilter]     [Bugtraq]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Linux ATA RAID]     [Samba]     [Device Mapper]
  Powered by Linux