On Mon, 2009-02-16 at 01:55 -0800, Luis R. Rodriguez wrote:
> >> +static inline
> >> +int wiphy_idx(struct wiphy *wiphy)
> >> +{
> >> + struct cfg80211_registered_device *drv;
> >> + if (!wiphy)
> >> + return WIPHY_IDX_STALE;
> >> + drv = wiphy_to_dev(wiphy);
> >> + return drv->wiphy_idx;
> >> +}
> >
> > I neither like the name of this function (same as the variable name) nor
> > the function -- you're using it in exactly one place where you cannot
> > ever pass NULL afaict.
>
> Nope, I'm calling it from 2 places:
>
> * Driver hints which never have the wiphy NULL
> * __regulatory_hint: called from 11d hints, and from the workqueue
> that processes the pending requests (which can come from userspace or
> from drivers right now).
Ok, but in the first case you can't have NULL, and in the second you
could just inline it. It's not an operation that requires an inline here
for it.
johannes
Attachment:
signature.asc
Description: This is a digitally signed message part
