Search Linux Wireless

Re: [PATCH 08/10] cfg80211: make regulatory_request use wiphy_idx instead of wiphy

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Fri, 2009-02-13 at 21:33 -0800, Luis R. Rodriguez wrote:

> +static inline
> +int wiphy_idx(struct wiphy *wiphy)
> +{
> +	struct cfg80211_registered_device *drv;
> +	if (!wiphy)
> +		return WIPHY_IDX_STALE;
> +	drv = wiphy_to_dev(wiphy);
> +	return drv->wiphy_idx;
> +}

I neither like the name of this function (same as the variable name) nor
the function -- you're using it in exactly one place where you cannot
ever pass NULL afaict.

johannes

Attachment: signature.asc
Description: This is a digitally signed message part


[Index of Archives]     [Linux Host AP]     [ATH6KL]     [Linux Bluetooth]     [Linux Netdev]     [Kernel Newbies]     [Linux Kernel]     [IDE]     [Security]     [Git]     [Netfilter]     [Bugtraq]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Linux ATA RAID]     [Samba]     [Device Mapper]
  Powered by Linux