Pavel Roskin wrote: > On Wed, 2009-01-21 at 21:55 +0300, Andrey Borzenkov wrote: >> Subject: [PATCH] orinoco: trivial cleanup in alloc_orinocodev >> From: Andrey Borzenkov <arvidjaar@xxxxxxx> >> >> Remove extra space; remove redundant cast >> >> Signed-off-by: Andrey Borzenkov <arvidjaar@xxxxxxx> > > Signed-off-by: Pavel Roskin <proski@xxxxxxx> > >> - if (! dev) >> + if (!dev) > > There are 41 occurrences of "(! " in drivers/net/wireless, all in > drivers/net/wireless/orinoco. Care to fix them all? > > By the way, I made a patch that adds all C sources in > drivers/net/wireless/orinoco and ran it through checkpatch.pl. There > were 226 errors and 174 warnings. That includes those spaces, trailing > whitespace, excessively long lines and so on. It would be great if you > fix at least some of that. Actually, long lines are justified in many > cases, so please don't overdo it. I've a patch series reorganising the orinoco driver a bit to help with future changes. It should fix a good proportion of those warnings. I plan to post it soon - so I'd appreciate it if you held off submitting further cleanup patches until I get it done (I'll try for the end of this week). I should be able to rebase around this one. Thanks, Dave. -- To unsubscribe from this list: send the line "unsubscribe linux-wireless" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
