On Wed, 2009-01-21 at 21:55 +0300, Andrey Borzenkov wrote: > Subject: [PATCH] orinoco: trivial cleanup in alloc_orinocodev > From: Andrey Borzenkov <arvidjaar@xxxxxxx> > > Remove extra space; remove redundant cast > > Signed-off-by: Andrey Borzenkov <arvidjaar@xxxxxxx> Signed-off-by: Pavel Roskin <proski@xxxxxxx> > - if (! dev) > + if (!dev) There are 41 occurrences of "(! " in drivers/net/wireless, all in drivers/net/wireless/orinoco. Care to fix them all? By the way, I made a patch that adds all C sources in drivers/net/wireless/orinoco and ran it through checkpatch.pl. There were 226 errors and 174 warnings. That includes those spaces, trailing whitespace, excessively long lines and so on. It would be great if you fix at least some of that. Actually, long lines are justified in many cases, so please don't overdo it. > - dev->wireless_handlers = (struct iw_handler_def *)&orinoco_handler_def; > + dev->wireless_handlers = &orinoco_handler_def; That's fine. -- Regards, Pavel Roskin -- To unsubscribe from this list: send the line "unsubscribe linux-wireless" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
