Search Linux Wireless

Re: [ath9k-devel] [PATCH] ath9k: Fix typo in chip version check

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Hello, Vasanthakumar!

On Wed, 2009-01-21 at 17:18 +0530, Vasanthakumar Thiagarajan wrote:
> Signed-off-by: Vasanthakumar Thiagarajan <vasanth@xxxxxxxxxxx>
> ---
>  drivers/net/wireless/ath9k/hw.c |    2 +-
>  1 files changed, 1 insertions(+), 1 deletions(-)

I'm not a developer of ath9k, and I don't know much about the hardware.
However, I think your patch should be better explained.

> -	if (AR_SREV_9280(ah)) {
> +	if (AR_SREV_9280_10_OR_LATER(ah)) {

It's not a typo.  A typo would be something like AR_SREV_9380, that is
never defined.  Or maybe a message like "foudn AR9280".  AR_SREV_9280 is
defined and has valid uses.  If you think it needs to be changed in this
particular case, an explanation is needed.  It would be nice if you
mentioned that it fixes something for some hardware.
 
-- 
Regards,
Pavel Roskin
--
To unsubscribe from this list: send the line "unsubscribe linux-wireless" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html

[Index of Archives]     [Linux Host AP]     [ATH6KL]     [Linux Bluetooth]     [Linux Netdev]     [Kernel Newbies]     [Linux Kernel]     [IDE]     [Security]     [Git]     [Netfilter]     [Bugtraq]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Linux ATA RAID]     [Samba]     [Device Mapper]
  Powered by Linux