On Tue, Jan 20, 2009 at 08:26:46PM +0300, Andrey Borzenkov wrote: > On 19 января 2009 06:16:04 Pavel Roskin wrote: > > On Sat, 2009-01-17 at 18:22 +0300, Andrey Borzenkov wrote: > > > Subject: [PATCH] [2.6.29-rc2] orinoco: use GFP_ATOMIC in kmalloc in > > > orinoco_ioctl_set_genie > > > From: Andrey Borzenkov <arvidjaar@xxxxxxx> > > > > > > kmalloc is called with interrupt disabled and may not sleep. This > > > fixes this BUG: > > > > Please move kmalloc before the lock. I don't see any reason to > > allocate memory with irqs disabled. The contention happens later, > > when priv->wpa_ie is freed and assigned a new value. > > OK. > > This looks like -stable candidate. Just FYI, the best way to indicate is to add a line like this after your Signed-off-by: Cc: stable@xxxxxxxxxx I'll take care of this one. Thanks, John -- John W. Linville Someday the world will need a hero, and you linville@xxxxxxxxxxxxx might be all we have. Be ready. -- To unsubscribe from this list: send the line "unsubscribe linux-wireless" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html