Search Linux Wireless

Re: [PATCH 07/12] cfg80211: allow driver read access to cfg80211_regdomain

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Tue, Jan 13, 2009 at 2:53 PM, Johannes Berg
<johannes@xxxxxxxxxxxxxxxx> wrote:
> On Tue, 2009-01-13 at 14:51 -0800, Luis R. Rodriguez wrote:
>> On Tue, Jan 13, 2009 at 02:46:59PM -0800, Johannes Berg wrote:
>> > On Tue, 2009-01-13 at 11:57 -0800, Luis R. Rodriguez wrote:
>> > > A driver's reg_notfier() may want to inspect the currently set
>> > > regulatory domain.
>> >
>> > > +const struct ieee80211_regdomain *cfg80211_regdomain;
>> > > +EXPORT_SYMBOL(cfg80211_regdomain);
>> >
>> > Can't we just pass it to the notifier instead of exporting it?
>>
>> I as thinking about that too, sure, either or is fine. Any preference?
>
> I prefer not exporting it. That makes it more local, and saves the
> export. Not that I see why we need it at all? You're not using it, so
> let's not do anything with it until we need it.

Actually -- you're right, I thought we needed in the reg_notifier()
but freq_reg_info() was used instead. Hmm, brain fart I guess. Good
catch.

  Luis
--
To unsubscribe from this list: send the line "unsubscribe linux-wireless" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html

[Index of Archives]     [Linux Host AP]     [ATH6KL]     [Linux Bluetooth]     [Linux Netdev]     [Kernel Newbies]     [Linux Kernel]     [IDE]     [Security]     [Git]     [Netfilter]     [Bugtraq]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Linux ATA RAID]     [Samba]     [Device Mapper]
  Powered by Linux