Search Linux Wireless

Re: [PATCH] ath5k: ignore the return value of ath5k_hw_noise_floor_calibration

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Sat, Jan 10, 2009 at 02:21:44AM +0100, darklight wrote:
> hi,
> 
> some weeks ago Felix Fietkau posted a patch for the "ath5k phy0:
> unsupported jumbo" warnings (see here:
> http://article.gmane.org/gmane.linux.kernel.wireless.general/23430 )
> I just had the same problem - after applying Felix' patch the warnings
> went down from 50-100 per day to 5.
> 
> as a quick note: I did not just apply this patch, instead I replaced
> Linus' upstream wireless stack with the one from wireless-testing
> (using kernel version 2.6.28)
> 
> I hope Felix' patch can get into Linus' kernel (mainline) so other
> users can profit from this

It is in Linus' kernel right now:

commit 8b0162a3dc5c30e862b7a73da29e32de3170f5e4
Author: Felix Fietkau <nbd@xxxxxxxxxxx>
Date:   Mon Nov 3 11:27:38 2008 +0100

    ath5k: ignore the return value of ath5k_hw_noise_floor_calibration

    Noise floor calibration occasionally fails on Atheros hardware.
    This is not fatal and can happen if there's simply too much
    noise on the air. Ignoring the calibration error is the right
    thing to do here, because when the error is ignored, the hardware
    will still work, whereas if the error causes the driver to bail out
    of a bigger configuration function and does not configure the tx
    queues or the IMR (as is the case in reset.c), the hw no longer
    works properly until the next reset.

    Signed-off-by: Felix Fietkau <nbd@xxxxxxxxxxx>
    Signed-off-by: John W. Linville <linville@xxxxxxxxxxxxx>

Hth!

John
-- 
John W. Linville		Someday the world will need a hero, and you
linville@xxxxxxxxxxxxx			might be all we have.  Be ready.
--
To unsubscribe from this list: send the line "unsubscribe linux-wireless" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html

[Index of Archives]     [Linux Host AP]     [ATH6KL]     [Linux Bluetooth]     [Linux Netdev]     [Kernel Newbies]     [Linux Kernel]     [IDE]     [Security]     [Git]     [Netfilter]     [Bugtraq]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Linux ATA RAID]     [Samba]     [Device Mapper]
  Powered by Linux