Search Linux Wireless

Re: [PATCH] Fix up truesize after pskb_expand_head() in wireless stack

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Mon, 2009-01-05 at 14:36 +0100, Andi Kleen wrote:
> On Mon, Jan 05, 2009 at 02:16:19PM +0100, Johannes Berg wrote:
> > > I didn't use any monitoring with this. No tcpdump, no wireless
> > > sniffer tools or anything. It happened all the time during
> > > normal operation.
> > 
> > You did have a monitor interface up though, didn't you? If nothing
> 
> wmaster0 was up. Is that a monitoring interface? 

No. Only if you do iwconfig ... mode monitor or use iw to create one or
something like that.

I was under the impression that you only modified monitor mode code, but
upon closer inspection (really, you should diff with -p, makes it a lot
easier to review) it seems that you also touched packet defragmentation
code. Are you running a low fragmentation threshold on your network?

Can you
check /sys/kernel/debug/ieee80211/phy*/statistics/rx_expand_skb_head*
please?

> > actually used those skbs then it's likely that the warning didn't result
> > in any corruption at all.
> 
> Nothing was corrupted ever to my knowledge, just lots of spam in my kernel logs.

You wouldn't easily notice any socket memory charge corruption anyway.

johannes

Attachment: signature.asc
Description: This is a digitally signed message part


[Index of Archives]     [Linux Host AP]     [ATH6KL]     [Linux Bluetooth]     [Linux Netdev]     [Kernel Newbies]     [Linux Kernel]     [IDE]     [Security]     [Git]     [Netfilter]     [Bugtraq]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Linux ATA RAID]     [Samba]     [Device Mapper]
  Powered by Linux