On Sun, Jan 04, 2009 at 06:33:08PM +0100, Johannes Berg wrote: > On Sun, 2009-01-04 at 18:43 +0100, Andi Kleen wrote: > > > > we need to do is figure out is why the skb has a wrong truesize. > > > > Because it was expanded without truesize being adjusted (see my > > original mail) > > So why is this not making trouble with all the other users? I think most adjustments are too small to be noticed. Typically they are just for a few bytes in the header. truesize is already larger, so it can tolerate some slag. I also only see it occasionally (maybe 5-10 times/day) when the wireless stack appends a lot of data. My proposal would be to include this patch for 2.6.28/2.6.29 and investigate fixing pskb_expand_head for 2.6.30. -Andi -- ak@xxxxxxxxxxxxxxx -- To unsubscribe from this list: send the line "unsubscribe linux-wireless" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
