On Wed, 2025-01-29 at 11:30 -0800, Pradeep Kumar Chitrapu wrote: Hello, > Yes, your understanding is correct.. So your patch actually does two things: - add support for fixed rate - fix default value sent for GI config to the firmware > If peer support SGI, param_value 1 is sent to firmware where firmware > switches between SGI/LGI based on packet error rate. This param value > 1 corresponds to NL80211_TXRATE_FORCE_SGI in nl80211. Is this what we really want ? I understand the nl80211 enum like this: NL80211_TXRATE_FORCE_SGI: => if STA supports SGI: use SGI only => if STA does not support SGI: use LGI only (or SGI only ? IDK) NL80211_TXRATE_FORCE_LGI: => always use LGI NL80211_TXRATE_DEFAULT_GI (no forcing) => if STA does not support SGI: use LGI only => if STA supports SGI: implementation defined, most likely SGI/LGI chosen by rate control Assuming my understanding is correct, should you not adapt ath12k_peer_assoc_h_ht() to match this semantic ? -- Maxime
