On 1/10/2025 2:49 PM, Johannes Berg wrote:
On Fri, 2025-01-10 at 09:54 +0530, Sarika Sharma wrote:
struct station_info {
+ struct link_station_info deflink;
Having a deflink here seems kind of questionable?
ohh! why so? In other structures like vif, sdata, sta, we did the same
way. So why can't we have the same way here as well?
Why not pass multiple pointers?
Sorry, I didn't get you.
Did you mean keep the sinfo structure and call this for filling all link
level, non-mL, ML information?
Also here I'd say you should split this better. Probably the whole
series needs some reorg for cfg80211/mac80211.
Sure, let me check what I can do here.
- if (!(sinfo->filled & BIT_ULL(NL80211_STA_INFO_TX_BITRATE)) &&
+ if (!(link_sinfo->filled & BIT_ULL(NL80211_STA_INFO_TX_BITRATE)) &&
A little less renaming would probably also make this easier to review.
Sure, but this is corresponding to filling link level data, that's why
just renaming sinfo to link_sinfo.
johannes
