Search Linux Wireless

Re: [PATCH RFC 2/7] wifi: cfg80211: reorg sinfo structure elements for MLO

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Fri, 2025-01-10 at 09:54 +0530, Sarika Sharma wrote:
> 
>  struct station_info {
> 
> +	struct link_station_info deflink;

Having a deflink here seems kind of questionable?

Why not pass multiple pointers?

Also here I'd say you should split this better. Probably the whole
series needs some reorg for cfg80211/mac80211.

> -	if (!(sinfo->filled & BIT_ULL(NL80211_STA_INFO_TX_BITRATE)) &&
> +	if (!(link_sinfo->filled & BIT_ULL(NL80211_STA_INFO_TX_BITRATE)) &&
> 

A little less renaming would probably also make this easier to review.

johannes





[Index of Archives]     [Linux Host AP]     [ATH6KL]     [Linux Wireless Personal Area Network]     [Linux Bluetooth]     [Wireless Regulations]     [Linux Netdev]     [Kernel Newbies]     [Linux Kernel]     [IDE]     [Git]     [Netfilter]     [Bugtraq]     [Yosemite Hiking]     [MIPS Linux]     [ARM Linux]     [Linux RAID]

  Powered by Linux