On Fri, 2025-01-10 at 09:54 +0530, Sarika Sharma wrote: > > struct station_info { > > + struct link_station_info deflink; Having a deflink here seems kind of questionable? Why not pass multiple pointers? Also here I'd say you should split this better. Probably the whole series needs some reorg for cfg80211/mac80211. > - if (!(sinfo->filled & BIT_ULL(NL80211_STA_INFO_TX_BITRATE)) && > + if (!(link_sinfo->filled & BIT_ULL(NL80211_STA_INFO_TX_BITRATE)) && > A little less renaming would probably also make this easier to review. johannes