On Wed, 4 Dec 2024 at 13:37, Donald Hunter <donald.hunter@xxxxxxxxx> wrote: > > On Wed, 4 Dec 2024 at 02:07, Jakub Kicinski <kuba@xxxxxxxxxx> wrote: > > > > > + if display_hint in ['ipv4', 'ipv6']: > > > + ip = ipaddress.ip_address(string) > > > + if type == 'binary': > > > + raw = ip.packed > > > + else: > > > + raw = int(ip) > > > + else: > > > > I wonder if we should raise in this case? > > Especially if type is binary passing the string back will just blow up > > later, right? We could instead rise with a nice clear error message > > here. > > It's actually a bit misleading that the attr is called 'string' > because it could be a binary input if it was supplied from python > code, i.e. not parsed from JSON on the command-line. I was wrong, the binary input is handled already by the caller, so this should just raise an exception.
