On Tue, 3 Dec 2024 13:06:52 +0000 Donald Hunter wrote: > + def _from_string(self, string, display_hint, type): Any reason not to pass attr_spec instead of the members one by one? > + if display_hint in ['ipv4', 'ipv6']: > + ip = ipaddress.ip_address(string) > + if type == 'binary': > + raw = ip.packed > + else: > + raw = int(ip) > + else: I wonder if we should raise in this case? Especially if type is binary passing the string back will just blow up later, right? We could instead rise with a nice clear error message here. > + raw = string > + return raw
