Search Linux Wireless

Re: [PATCH v2] wifi: mac80211: fix mbss changed flags corruption on 32 bit systems

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Mon, 2024-11-18 at 13:26 +0000, James Dutton wrote:
> 
> > @@ -1157,14 +1157,14 @@ void ieee80211_mbss_info_change_notify(struct ieee80211_sub_if_data *sdata,
> >                                        u64 changed)
> >  {
> >         struct ieee80211_if_mesh *ifmsh = &sdata->u.mesh;
> > -       unsigned long bits = changed;
> > +       unsigned long bits[] = { BITMAP_FROM_U64(changed) };
> 
> Wouldn't it be easier to use this instead:
> -       unsigned long bits = changed;
> +       u64 bits = changed;

No, that's incorrect for set_bit() etc. at least on 32-bit big-endian
systems. Then you can't use for_each_set_bit() etc.

johannes





[Index of Archives]     [Linux Host AP]     [ATH6KL]     [Linux Wireless Personal Area Network]     [Linux Bluetooth]     [Wireless Regulations]     [Linux Netdev]     [Kernel Newbies]     [Linux Kernel]     [IDE]     [Git]     [Netfilter]     [Bugtraq]     [Yosemite Hiking]     [MIPS Linux]     [ARM Linux]     [Linux RAID]

  Powered by Linux