Re: [PATCH v2] wifi: mac80211: fix mbss changed flags corruption on 32 bit systems

[James Dutton <james.dutton@xxxxxxxxx>]

On Mon, 18 Nov 2024 at 12:56, Issam Hamdi <ih@xxxxxxxxxxxxxxxxxx> wrote:
> ---
> Changes in v2:
> - Use BITMAP_FROM_U64() to map all the 64 bits.
> - Update the commit description.
> ---
>  net/mac80211/mesh.c | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/net/mac80211/mesh.c b/net/mac80211/mesh.c
> index cb5f16366b9c..e420eb4797a8 100644
> --- a/net/mac80211/mesh.c
> +++ b/net/mac80211/mesh.c
> @@ -1157,14 +1157,14 @@ void ieee80211_mbss_info_change_notify(struct ieee80211_sub_if_data *sdata,
>                                        u64 changed)
>  {
>         struct ieee80211_if_mesh *ifmsh = &sdata->u.mesh;
> -       unsigned long bits = changed;
> +       unsigned long bits[] = { BITMAP_FROM_U64(changed) };

Wouldn't it be easier to use this instead:
-       unsigned long bits = changed;
+       u64 bits = changed;