On Thu, Jun 20, 2024 at 08:53:45PM +0200, Christophe JAILLET wrote: > Le 20/06/2024 à 20:08, Gustavo A. R. Silva a écrit : > > > > > > On 6/20/24 12:02, Gustavo A. R. Silva wrote: > > > > > > > My understanding is that 'match', is allocated by : > > > > match = kzalloc(struct_size(match, channels, n_channels), > > > > GFP_KERNEL); > > > > > > > > So match->n_channels is *0* when iwl_mvm_query_set_freqs() is called. > > > > > > n_channels is updated in the line before calling kzalloc(): > > > > > > n_channels = iwl_mvm_query_num_match_chans(mvm, d3_data->nd_results, i); > > > > > > match = kzalloc(struct_size(match, channels, n_channels), GFP_KERNEL); > > > > then match->n_channels updated here: > > > > if (!match) > > goto out_report_nd; > > + match->n_channels = n_channels; > > Thanks for the explanation. > This is what I was looking for, and I missed this line. > > Sorry for the noise. Hi, This patch is still needed and doesn't appear in -next (nor Linus's tree). Should I resend it? Thanks! -Kees -- Kees Cook