On 30/10/2024 04:54, Ping-Ke Shih wrote: >>> >>> Smatch warns >>> >>> drivers/net/wireless/realtek/rtw88/rtw8812a.c:619 rtw8812a_iqk() error: uninitialized symbol >> 'tx_x1'. >>> drivers/net/wireless/realtek/rtw88/rtw8812a.c:621 rtw8812a_iqk() error: uninitialized symbol >> 'tx_y1'. >>> >> >> These are false positives. The variables are initialised inside >> rtw88xxa_iqk_finish(). But I'll initialise them when they are >> declared. > > I see, but the setting under conditions. > > By the way, tx_x0 and tx_y0 are very similar pattern, but smatch doesn't > warn them. Please run smatch again after you fix tx_x1/tx_y1. > > Yes, I expect it to complain about all those eight variables, but it doesn't, even after I fixed tx_x1 and tx_y1. But I initialised them all just in case.
