Felix Fietkau <nbd@xxxxxxxx> wrote: > If mcu_skb_prepare_msg is not implemented, incrementing skb refcount does not > work for mcu message retry. In some cases (e.g. on SDIO), shared skbs can trigger > a BUG_ON, crashing the system. > Fix this by only incrementing refcount if retry is actually supported. > > Fixes: 3688c18b65ae ("wifi: mt76: mt7915: retry mcu messages") > Closes: https://lore.kernel.org/r/d907b13a-f8be-4cb8-a0bb-560a21278041@notapiano/ > Reported-by: Nícolas F. R. A. Prado <nfraprado@xxxxxxxxxxxxx> #KernelCI > Tested-by: Alper Nebi Yasak <alpernebiyasak@xxxxxxxxx> > Signed-off-by: Felix Fietkau <nbd@xxxxxxxx> Patch applied to wireless.git, thanks. 34b695481084 wifi: mt76: do not increase mcu skb refcount if retry is not supported -- https://patchwork.kernel.org/project/linux-wireless/patch/20240917110942.22077-1-nbd@xxxxxxxx/ https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches