Re: [PATCH] wifi: mt76: do not increase mcu skb refcount if retry is not supported

[Felix Fietkau <nbd@xxxxxxxx>]

On 17.09.24 13:18, Kalle Valo wrote:
> Felix Fietkau <nbd@xxxxxxxx> writes:
>
> > If mcu_skb_prepare_msg is not implemented, incrementing skb refcount does not
> > work for mcu message retry. In some cases (e.g. on SDIO), shared skbs can trigger
> > a BUG_ON, crashing the system.
> > Fix this by only incrementing refcount if retry is actually supported.
> >
> > Fixes: 3688c18b65ae ("wifi: mt76: mt7915: retry mcu messages")
> > Reported-by: Nícolas F. R. A. Prado <nfraprado@xxxxxxxxxxxxx> #KernelCI
> > Tested-by: Alper Nebi Yasak <alpernebiyasak@xxxxxxxxx>
> > Signed-off-by: Felix Fietkau <nbd@xxxxxxxx>
>
> I'll queue this to wireless tree and add:
>
> Closes: https://lore.kernel.org/r/d907b13a-f8be-4cb8-a0bb-560a21278041@notapiano/
>
> Ok?

Sure, thanks!

- Felix