On Tue, Sep 03, 2024 at 01:51:46AM +0000, David Lin wrote: > > From: Sascha Hauer <s.hauer@xxxxxxxxxxxxxx> > > Sent: Monday, September 2, 2024 9:11 PM > > To: David Lin <yu-hao.lin@xxxxxxx> > > Cc: Francesco Dolcini <francesco@xxxxxxxxxx>; Calvin Owens > > <calvin@xxxxxxxxxx>; Brian Norris <briannorris@xxxxxxxxxxxx>; Kalle Valo > > <kvalo@xxxxxxxxxx>; linux-wireless@xxxxxxxxxxxxxxx; > > linux-kernel@xxxxxxxxxxxxxxx; kernel@xxxxxxxxxxxxxx > > Subject: Re: [EXT] [RFC PATCH 0/4] mwifiex: add support for iw61x > > > > > > > > > > > > > > > > > > Sascha > > > > > > > > > > > > > > > > > > > > > > > > Sascha Hauer (4): > > > > > > > > wifi: mwifiex: release firmware at remove time > > > > > > > > wifi: mwifiex: handle VDLL > > > > > > > > wifi: mwifiex: wait longer for SDIO card status > > > > > > > > mwifiex: add iw61x support > > > > > > > > > > > > > > > > drivers/net/wireless/marvell/mwifiex/cmdevt.c | 86 > > > > > > +++++++++++++++++++ > > > > > > > > drivers/net/wireless/marvell/mwifiex/fw.h | 16 ++++ > > > > > > > > drivers/net/wireless/marvell/mwifiex/main.c | 9 +- > > > > > > > > drivers/net/wireless/marvell/mwifiex/main.h | 4 + > > > > > > > > drivers/net/wireless/marvell/mwifiex/sdio.c | 81 > > > > ++++++++++++++++- > > > > > > > > drivers/net/wireless/marvell/mwifiex/sdio.h | 3 + > > > > > > > > .../net/wireless/marvell/mwifiex/sta_event.c | 4 > > > > > > > > + .../net/wireless/marvell/mwifiex/uap_event.c | 4 + > > > > > > > > include/linux/mmc/sdio_ids.h | 3 + > > > > > > > > 9 files changed, 205 insertions(+), 5 deletions(-) > > > > > > > > > > > > > > > > -- > > > > The VDLL support in the downstream driver supports a case when a > > > > VDLL event comes in while a command is being sent. I catched this > > > > with this > > > > test: > > > > > > > > if (adapter->cmd_sent) { > > > > mwifiex_dbg(adapter, MSG, "%s: adapter is busy\n", > > > > __func__); > > > > return -EBUSY; > > > > } > > > > > > > > The downstream driver defers handling of the VDLL event to the main > > > > process in this case. I haven't implemented this case in my patch > > > > because I wasn't able to trigger it, but is this the case you are referring to? > > > > > > > > > > Not only this code segment. In fact, you did not add VDLL data patch support > > to sdio.c. > > > If you try to add the code and do test, you will know what is missing in your > > code. > > > > Could you point me to the code you mean? > > > > Sascha > > > > I only know the porting VDLL code in nxpwifi. Yes, and I asked for a pointer to that code, some function name, or file/line or whatever, because I looked at the nxpwifi driver and don't know what you mean with "VDLL data patch support" in sdio.c. Sascha -- Pengutronix e.K. | | Steuerwalder Str. 21 | http://www.pengutronix.de/ | 31137 Hildesheim, Germany | Phone: +49-5121-206917-0 | Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917-5555 |