On 30/08/2024 03:30, Ping-Ke Shih wrote: > Hi Bitterblue, > > Bitterblue Smith <rtl8821cerfe2@xxxxxxxxx> wrote: >> >> All USB devices supported by rtw88 have the same problem: they don't >> transmit beacons in AP mode. (Some?) SDIO devices are also affected. >> The cause appears to be clearing BIT_EN_BCNQ_DL of REG_FWHW_TXQ_CTRL >> before uploading the beacon reserved page, so don't clear the bit for >> USB and SDIO devices. >> >> Tested with RTL8811CU and RTL8723DU. >> >> Cc: <stable@xxxxxxxxxxxxxxx> # 6.6.x >> Signed-off-by: Bitterblue Smith <rtl8821cerfe2@xxxxxxxxx> > > Can I say two below patchset are equivalent in your side? > > [Patchset 1: your v1] > 13744097 New [1/2] wifi: rtw88: Fix USB devices not transmitting beacons > 13744098 New [2/2] wifi: rtw88: Avoid using macid 0 in AP mode > > [Patchset 2: your v2 + mine] > 13771597 New [v2] wifi: rtw88: Fix USB/SDIO devices not transmitting beacons > 13767746 New wifi: rtw88: assign mac_id for vif/sta and update to TX desc > > If this can make AP mode on USB devices step forward, I will merge them ahead. > Yes, patchset 2 works for me.