On 2024/8/27 15:25, Johannes Berg wrote:
On Tue, 2024-08-27 at 11:03 +0800, Hongbo Li wrote:
The following Coccinelle/coccicheck warning reported by
minmax.cocci:
WARNING opportunity for max()
Yeah well, maybe sometimes we shouldn't blindly follow tools ...
Let's use max() to simplify the code and fix the warning.
You should explain why.
I think only one out of four changes in this patch is correct,
semantically.
You mean sometimes we should keep the variable type in comparison?
Thanks,
Hongbo
johannes
