On Tue, 2024-08-27 at 11:03 +0800, Hongbo Li wrote: > The following Coccinelle/coccicheck warning reported by > minmax.cocci: > WARNING opportunity for max() Yeah well, maybe sometimes we shouldn't blindly follow tools ... > Let's use max() to simplify the code and fix the warning. You should explain why. I think only one out of four changes in this patch is correct, semantically. johannes