On 8/19/24 09:17, Marek Vasut wrote:
On 8/19/24 5:52 PM, Arend Van Spriel wrote:
Hi,
Add support to download TRX firmware for PCIe and SDIO.
Signed-off-by: Chung-Hsien Hsu <chung-hsien.hsu@xxxxxxxxxxxx>
Signed-off-by: Marek Vasut <marex@xxxxxxx> # Upport to current
linux-next
The commit message should answer to the question 'Why?'. What's TRX
firmware and why do we need it?
I looked over the patches, but did not sit down to comment on this.
Thanks, it is real nice that someone who is actually familiar with the
hardware jumped in. I only upported the patches from infineon downstream.
The TRX firmware format allows multiple images and possibly
compression. Not sure if Infineon is using all this functionality.
This is probably needed for 55572 device support (patch 2/2). Turns
out this device has a bootloader that the driver has to talk with and
that is probably where this TRX support comes from. Not something I
considered to happen for SDIO and PCIe devices. There is always a
puzzle to solve ;-)
Also noticed a random seed is provided to firmware. This already there
for apple chips so it should be looked at whether that code can be
shared. I will follow up.
I did notice just now there is some TRX support for USB broadcom devices ?
TRX is a format that is also used for partitioning flash devices, so
there is probably some room for making a common header:
./Documentation/devicetree/bindings/mtd/partitions/brcm,trx.txt/drivers/mtd/parsers/parser_trx.c
--
Florian
