On August 19, 2024 4:36:05 PM Kalle Valo <kvalo@xxxxxxxxxx> wrote:
Marek Vasut <marex@xxxxxxx> writes:
From: Chung-Hsien Hsu <stanley.hsu@xxxxxxxxxxx>
Add support to download TRX firmware for PCIe and SDIO.
Signed-off-by: Chung-Hsien Hsu <chung-hsien.hsu@xxxxxxxxxxxx>
Signed-off-by: Marek Vasut <marex@xxxxxxx> # Upport to current linux-next
The commit message should answer to the question 'Why?'. What's TRX
firmware and why do we need it?
I looked over the patches, but did not sit down to comment on this. The TRX
firmware format allows multiple images and possibly compression. Not sure
if Infineon is using all this functionality. This is probably needed for
55572 device support (patch 2/2). Turns out this device has a bootloader
that the driver has to talk with and that is probably where this TRX
support comes from. Not something I considered to happen for SDIO and PCIe
devices. There is always a puzzle to solve ;-)
Also noticed a random seed is provided to firmware. This already there for
apple chips so it should be looked at whether that code can be shared. I
will follow up.
Regards,
Arend
--
https://patchwork.kernel.org/project/linux-wireless/list/
https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches
