Hi, I tested this on RK3588 EVB1 and the driver is working fine. The DT bindings are not correct, though: linux/arch/arm64/boot/dts/rockchip/rk3588-evb1-v10.dtb: wifi@0,0: compatible: 'oneOf' conditional failed, one must be fixed: ['pci14e4,449d', 'brcm,bcm4329-fmac'] is too long 'pci14e4,449d' is not one of ['brcm,bcm43143-fmac', 'brcm,bcm4341b0-fmac', 'brcm,bcm4341b4-fmac', 'brcm,bcm4341b5-fmac', 'brcm,bcm4329-fmac', 'brcm,bcm4330-fmac', 'brcm,bcm4334-fmac', 'brcm,bcm43340-fmac', 'brcm,bcm4335-fmac', 'brcm,bcm43362-fmac', 'brcm,bcm4339-fmac', 'brcm,bcm43430a0-fmac', 'brcm,bcm43430a1-fmac', 'brcm,bcm43455-fmac', 'brcm,bcm43456-fmac', 'brcm,bcm4354-fmac', 'brcm,bcm4356-fmac', 'brcm,bcm4359-fmac', 'brcm,bcm4366-fmac', 'cypress,cyw4373-fmac', 'cypress,cyw43012-fmac', 'infineon,cyw43439-fmac'] from schema $id: http://devicetree.org/schemas/net/wireless/brcm,bcm4329-fmac.yaml# It's easy to see the problem in the binding. It does not expect a fallback string after the PCI ID based compatible. Either the pci14e4,449d entry must be added to the first enum in the binding, which has the fallback compatible, or the fallback compatible should not be added to DTS. If the fallback compatible is missing in DTS, the compatible check in brcmf_of_probe() fails and the lpo clock is not requested resulting in the firmware startup failing. So that would require further driver changes. Greetings, -- Sebastian
Attachment:
signature.asc
Description: PGP signature
