On Fri, 2008-12-12 at 14:38 +0200, Jouni Malinen wrote:
> --- wireless-testing.orig/net/mac80211/rx.c 2008-12-12 00:26:04.000000000 +0200
> +++ wireless-testing/net/mac80211/rx.c 2008-12-12 14:09:52.000000000 +0200
> @@ -149,7 +149,17 @@ ieee80211_add_rx_radiotap_header(struct
> pos++;
>
> /* IEEE80211_RADIOTAP_RATE */
> - *pos = rate->bitrate / 5;
> + if (status->flag & RX_FLAG_HT) {
> + /*
> + * TODO: add following information into radiotap header once
> + * suitable fields are defined for it:
> + * - MCS index (status->rate_idx)
> + * - HT40 (status->flag & RX_FLAG_40MHZ)
> + * - short-GI (status->flag & RX_FLAG_SHORT_GI)
> + */
> + *pos = 0;
> + } else
> + *pos = rate->bitrate / 5;
> pos++;
I think we should also unset the 1<<IEEE80211_RADIOTAP_RATE bit in the
HT case so the *pos = 0 will just be padding to dissectors. That's
correct then because the field after this (channel) requires 2-byte
alignment.
johannes
Attachment:
signature.asc
Description: This is a digitally signed message part
